Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move jack_control command handlers to own functions #700

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dj-foxxy
Copy link

@dj-foxxy dj-foxxy commented Jan 7, 2021

I've tried to change as little as possible within the handlers. I've switched our setup to use this version so will be testing it.

@nedko
Copy link
Contributor

nedko commented Sep 10, 2022

This commit breaks python2 compatibility of jack_control

While I like the intent, in LADI/jackdbus I'm playing conservative and keeping python2 compatibility, for its stable interface (even if it has other issues) and thus the non-deployability to python2 systems is a concern.

@falkTX
Copy link
Member

falkTX commented Sep 10, 2022

main jack2 doesnt care about python2, any recent enough distribution does not provide it as it is unmaintained by a very long time and is now a security risk.

there was some initial work to move from waf to meson, which will help with this.

@dj-foxxy
Copy link
Author

Hi all. We've moved away from JACK so I'm unlikely to work on this PR. Feel free to close. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants