Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retune or-in-for/and-to-filter-clause #357

Closed
jackfirth opened this issue Oct 7, 2024 · 0 comments · Fixed by #359
Closed

Retune or-in-for/and-to-filter-clause #357

jackfirth opened this issue Oct 7, 2024 · 0 comments · Fixed by #359
Labels
bug Something isn't working existing lint Issues or pull requests relating to existing lints

Comments

@jackfirth
Copy link
Owner

See racket/typed-racket#1400. Perhaps this rule should only fire if the last condition is sufficiently complex and the leading conditions are simple.
@jackfirth jackfirth added bug Something isn't working existing lint Issues or pull requests relating to existing lints labels Oct 7, 2024
@jackfirth jackfirth mentioned this issue Oct 7, 2024
Merged
jackfirth added a commit that referenced this issue Oct 7, 2024
@jackfirth
Restrict or-in-for/and refactoring to obviously useful cases
fc00b4f 
Closes #357. Now it only fires if the last clause uses `let`, since that probably means the `or` is just serving as a way to get some simple cases out of the way before the main logic of the loop body.
@jackfirth jackfirth mentioned this issue Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working existing lint Issues or pull requests relating to existing lints
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restrict or-in-for/and refactoring to obviously useful cases jackfirth/resyntax
1 participant
@jackfirth