Automated Resyntax fixes #1400
Merged
Automated Resyntax fixes #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This is an automated change generated by Resyntax. #### Pass 1 Applied 2 fixes to [`typed-racket-lib/typed-racket/optimizer/optimizer.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/optimizer.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 92, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. Applied 2 fixes to [`typed-racket-lib/typed-racket/optimizer/pair.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/pair.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 77, `datum->syntax-migration`: The fifth argument to `datum->syntax` is ignored. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/vector.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/vector.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 2 fixes to [`typed-racket-lib/typed-racket/optimizer/fixnum.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/fixnum.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 127, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. Applied 2 fixes to [`typed-racket-lib/typed-racket/optimizer/float.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/float.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 139, `or-in-for/and-to-filter-clause`: The `or` expression in this `for` loop can be replaced by a filtering clause. Applied 2 fixes to [`typed-racket-lib/typed-racket/optimizer/float-complex.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/float-complex.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 85, `if-let-to-cond`: `cond` with internal definitions is preferred over `if` with `let`, to reduce nesting Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/struct.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/struct.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/unboxed-tables.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/unboxed-tables.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/list.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/list.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/number.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/number.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/box.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/box.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/hidden-costs.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/hidden-costs.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/numeric-utils.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/numeric-utils.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 3 fixes to [`typed-racket-lib/typed-racket/optimizer/logging.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/logging.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 93, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 104, `map-to-for`: This `map` operation can be replaced with a `for/list` loop. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/dead-code.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/dead-code.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/apply.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/apply.rkt) * Line 2, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/extflonum.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/extflonum.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 2 fixes to [`typed-racket-lib/typed-racket/optimizer/utils.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/utils.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 53, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/string.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/string.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. Applied 1 fix to [`typed-racket-lib/typed-racket/optimizer/unboxed-let.rkt`](../blob/HEAD/typed-racket-lib/typed-racket/optimizer/unboxed-let.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. ## Summary Fixed 28 issues in 20 files. * Fixed 20 occurrences of `tidy-require` * Fixed 4 occurrences of `let-to-define` * Fixed 1 occurrence of `datum->syntax-migration` * Fixed 1 occurrence of `or-in-for/and-to-filter-clause` * Fixed 1 occurrence of `if-let-to-cond` * Fixed 1 occurrence of `map-to-for`
samth
reviewed
Oct 7, 2024
samth
reviewed
Oct 7, 2024
| (for/list ([irritant (in-list (sort irritants | ||
| < | ||
| #:key (lambda (x) (or (syntax-position x) 0))))]) | ||
| (let ([irritant (locate-stx irritant)]) |
There was a problem hiding this comment.
No, it's shadowing the irritant loop variable.
sorawee
reviewed
Oct 7, 2024
| (define new-o | ||
| (mark-as-non-float (quasisyntax/loc this-syntax | ||
| (#,op #,(or o-nf o) #,(or c1-nf c1))))) | ||
| (if (stx-null? (stx-cdr cs)) new-o (loop new-o (stx-cdr cs)))] |
There was a problem hiding this comment.
This should not be collapsed to one line with the fmt PR that @9999years is proposing.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 20 files in this pull request and found no issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated change generated by Resyntax.
Pass 1
Applied 2 fixes to
typed-racket-lib/typed-racket/optimizer/optimizer.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.let-to-define: Internal definitions are recommended instead ofletexpressions, to reduce nesting.Applied 2 fixes to
typed-racket-lib/typed-racket/optimizer/pair.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.datum->syntax-migration: The fifth argument todatum->syntaxis ignored.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/vector.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 2 fixes to
typed-racket-lib/typed-racket/optimizer/fixnum.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.let-to-define: Internal definitions are recommended instead ofletexpressions, to reduce nesting.Applied 2 fixes to
typed-racket-lib/typed-racket/optimizer/float.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.or-in-for/and-to-filter-clause: Theorexpression in thisforloop can be replaced by a filtering clause.Applied 2 fixes to
typed-racket-lib/typed-racket/optimizer/float-complex.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.if-let-to-cond:condwith internal definitions is preferred overifwithlet, to reduce nestingApplied 1 fix to
typed-racket-lib/typed-racket/optimizer/struct.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/unboxed-tables.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/list.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/number.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/box.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/hidden-costs.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/numeric-utils.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 3 fixes to
typed-racket-lib/typed-racket/optimizer/logging.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.let-to-define: Internal definitions are recommended instead ofletexpressions, to reduce nesting.map-to-for: Thismapoperation can be replaced with afor/listloop.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/dead-code.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/apply.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/extflonum.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 2 fixes to
typed-racket-lib/typed-racket/optimizer/utils.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.let-to-define: Internal definitions are recommended instead ofletexpressions, to reduce nesting.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/string.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Applied 1 fix to
typed-racket-lib/typed-racket/optimizer/unboxed-let.rkttidy-require: Keep imports inrequiresorted and grouped by phase, with collections before files.Summary
Fixed 28 issues in 20 files.
tidy-requirelet-to-definedatum->syntax-migrationor-in-for/and-to-filter-clauseif-let-to-condmap-to-for