Mark useOtelWithSDKConfigurationForInternalTelemetry as stable (open-…

…telemetry#11202)

Signed-off-by: Bogdan Drutu <[email protected]>

.chloggen/stable-useOtelWithSDKConfigurationForInternalTelemetry.yaml

@@ -0,0 +1,20 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: 'enhancement'
+
+# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
+component: service/telemetry
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Mark useOtelWithSDKConfigurationForInternalTelemetry as stable
+
+# One or more tracking issues or pull requests related to the change
+issues: [7532]
+
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [user]

docs/observability.md

@@ -109,19 +109,8 @@ The process to generate new metrics is to configure them via
 
 ## Experimental trace telemetry
 
-The Collector does not expose traces by default, but an effort is underway to
-[change this][issue7532]. The work includes supporting configuration of the
-OpenTelemetry SDK used to produce the Collector's internal telemetry. This
-feature is behind two feature gates:
-
-```bash
-  --feature-gates=telemetry.useOtelWithSDKConfigurationForInternalTelemetry
-```
-
-The gate `useOtelWithSDKConfigurationForInternalTelemetry` enables the Collector
-to parse any configuration that aligns with the [OpenTelemetry Configuration]
-schema. Support for this schema is experimental, but it does allow telemetry to
-be exported using OTLP.
+The Collector does not expose traces by default, but can be configured.
+The Collector's internal telemetry uses OpenTelemetry SDK.
 
 The following configuration can be used in combination with the aforementioned
 feature gates to emit internal metrics and traces from the Collector to an OTLP

service/service.go

@@ -39,9 +39,10 @@ import (
 
 // useOtelWithSDKConfigurationForInternalTelemetryFeatureGate is the feature gate that controls whether the collector
 // supports configuring the OpenTelemetry SDK via configuration
-var useOtelWithSDKConfigurationForInternalTelemetryFeatureGate = featuregate.GlobalRegistry().MustRegister(
+var _ = featuregate.GlobalRegistry().MustRegister(
 	"telemetry.useOtelWithSDKConfigurationForInternalTelemetry",
-	featuregate.StageBeta,
+	featuregate.StageStable,
+	featuregate.WithRegisterToVersion("v0.110.0"),
 	featuregate.WithRegisterDescription("controls whether the collector supports extended OpenTelemetry"+
 		"configuration for internal telemetry"))
 
@@ -180,12 +181,12 @@ func New(ctx context.Context, set Settings, cfg Config) (*Service, error) {
 }
 
 func logsAboutMeterProvider(logger *zap.Logger, cfg telemetry.MetricsConfig, mp metric.MeterProvider) {
-	if cfg.Level == configtelemetry.LevelNone || (cfg.Address == "" && len(cfg.Readers) == 0) {
+	if cfg.Level == configtelemetry.LevelNone || len(cfg.Readers) == 0 {
 		logger.Info("Skipped telemetry setup.")
 		return
 	}
 
-	if len(cfg.Address) != 0 && useOtelWithSDKConfigurationForInternalTelemetryFeatureGate.IsEnabled() {
+	if len(cfg.Address) != 0 {
 		logger.Warn("service::telemetry::metrics::address is being deprecated in favor of service::telemetry::metrics::readers")
 	}