Skip to content

Commit

Permalink
Remove 0.0.0.0 overrides in HotROD CI (#6226)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Part of #6209
- The example should be working without these overrides

## Description of the changes
- Remove overrides
- Add explicit 0.0.0.0 host to all-in-one config

## How was this change tested?
- CI

---------

Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
yurishkuro authored Nov 20, 2024
1 parent 295146c commit 8c2340c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
9 changes: 7 additions & 2 deletions cmd/jaeger/internal/all-in-one.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ extensions:
# sampling_store: some_store
# initial_sampling_probability: 0.1
http:
endpoint: "0.0.0.0:5778"
grpc:
endpoint: "0.0.0.0:5779"

healthcheckv2:
use_v2: true
Expand All @@ -50,16 +52,19 @@ receivers:
otlp:
protocols:
grpc:
endpoint: "0.0.0.0:4317"
http:
endpoint: "0.0.0.0:4318"

jaeger:
protocols:
grpc:
thrift_binary:
thrift_compact:
endpoint: "0.0.0.0:14250"
thrift_http:
endpoint: "0.0.0.0:14268"

zipkin:
endpoint: "0.0.0.0:9411"

processors:
batch:
Expand Down
3 changes: 0 additions & 3 deletions examples/hotrod/docker-compose-v2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
services:
jaeger:
image: ${REGISTRY:-}jaegertracing/jaeger:${JAEGER_VERSION:-latest}
command:
- --set=receivers.otlp.protocols.grpc.endpoint="0.0.0.0:4317"
- --set=receivers.otlp.protocols.http.endpoint="0.0.0.0:4318"
ports:
- "16686:16686"
- "4317:4317"
Expand Down

0 comments on commit 8c2340c

Please sign in to comment.