-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger-v2] Release process #5889
Labels
Comments
yurishkuro
added a commit
that referenced
this issue
Aug 27, 2024
## Which problem is this PR solving? - Part of #5889 ## Description of the changes - Move semver-from-tag determination from Makefile into `scripts/compute-version.sh` - Move Go build info and Windows build info to dedicated Makefiles - Fixed execute permissions on all scripts ## How was this change tested? - ran windows build and jaeger / query builds to ensure expected behavior --------- Signed-off-by: Yuri Shkuro <[email protected]>
This was referenced Aug 27, 2024
yurishkuro
added a commit
that referenced
this issue
Aug 27, 2024
## Which problem is this PR solving? - Part of #5889 ## Description of the changes - Replace `make echo-version` with two separate v1/v2 targets, using new vars introduced in #5890 - Refactor `scripts/package-deploy.sh` to publish 2.x bundle ## How was this change tested? - `$ TARCMD=gtar bash scripts/package-deploy.sh -d` --------- Signed-off-by: Mend Renovate <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this issue
Aug 28, 2024
## Which problem is this PR solving? - Part of jaegertracing#5889 ## Description of the changes - Move semver-from-tag determination from Makefile into `scripts/compute-version.sh` - Move Go build info and Windows build info to dedicated Makefiles - Fixed execute permissions on all scripts ## How was this change tested? - ran windows build and jaeger / query builds to ensure expected behavior --------- Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: Jared Tan <[email protected]>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this issue
Aug 28, 2024
## Which problem is this PR solving? - Part of jaegertracing#5889 ## Description of the changes - Replace `make echo-version` with two separate v1/v2 targets, using new vars introduced in jaegertracing#5890 - Refactor `scripts/package-deploy.sh` to publish 2.x bundle ## How was this change tested? - `$ TARCMD=gtar bash scripts/package-deploy.sh -d` --------- Signed-off-by: Mend Renovate <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Jared Tan <[email protected]>
mahadzaryab1
pushed a commit
to mahadzaryab1/jaeger
that referenced
this issue
Aug 31, 2024
## Which problem is this PR solving? - Part of jaegertracing#5889 ## Description of the changes - Move semver-from-tag determination from Makefile into `scripts/compute-version.sh` - Move Go build info and Windows build info to dedicated Makefiles - Fixed execute permissions on all scripts ## How was this change tested? - ran windows build and jaeger / query builds to ensure expected behavior --------- Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
pushed a commit
to mahadzaryab1/jaeger
that referenced
this issue
Aug 31, 2024
## Which problem is this PR solving? - Part of jaegertracing#5889 ## Description of the changes - Replace `make echo-version` with two separate v1/v2 targets, using new vars introduced in jaegertracing#5890 - Refactor `scripts/package-deploy.sh` to publish 2.x bundle ## How was this change tested? - `$ TARCMD=gtar bash scripts/package-deploy.sh -d` --------- Signed-off-by: Mend Renovate <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
added a commit
that referenced
this issue
Sep 3, 2024
## Which problem is this PR solving? - Part of #5889 - `build-binaries-***` Makefile targets sometimes include os-arch, sometimes just os, sometimes just arch - it's a mess ## Description of the changes - normalize all targets to be `build-binaries-$os-$arch` - change `ci-build-binaries.yml` workflow to use `make echo-platforms` for the jobs matrix ## How was this change tested? - ci --------- Signed-off-by: Yuri Shkuro <[email protected]>
This was referenced Sep 9, 2024
yurishkuro
added a commit
that referenced
this issue
Sep 14, 2024
## Which problem is this PR solving? - Part of #5889 ## Description of the changes - simplify all-in-one publishing by minimizing number of parameters passed from workflow (v1/v2 only instead of binary name and healthcheck flag - those are now set inside the script) - implement overwrite `-o` flag in docker scripts to avoid accidental overriding of numbered releases - simplify flags management in docker scripts via FLAGS array instead of individual variables - fix base image building to respect selected platforms (by default it was building all) - allow `scripts/compute-version.sh` to accept semver with `-rcN` suffix ## How was this change tested? - CI - ran publish-release workflow manually https://github.com/jaegertracing/jaeger/actions/runs/10865002272/job/30150937690 --------- Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We plan to continue supporting v1 components even after we release Jaeger v2, at least for a year. During that period we need to enhance our release process such that both v1 and v2 artifacts are published, as well as make the corresponding changes to the documentation.
Proposed release process:
main
branch ofjaeger
repository2.0.0-rcN
and we will keep incrementingN
.2.0.0-rc1/1.61.0
jaeger
binaryTasks:
scripts/package-deploy.sh
or define temporary keylatest
now)scripts/package-deploy.sh
)build-binaries-***
Makefile targets, they sometimes include os-arch, sometimes just os, simetimes just arch - it's a mess -- Normalize build-binaries targets #5924release/published
event or rather on tags?RELEASE.md
. Because we need two tags in the repo, they have to be applied manually, not via GH Release, which can only create one tag.The text was updated successfully, but these errors were encountered: