[ci] Add support for v2 tags during build #5890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
added
the
changelog:ci
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5890 +/- ##
==========================================
+ Coverage 96.82% 96.84% +0.01%
==========================================
Files 342 342
Lines 16520 16520
==========================================
+ Hits 15996 15998 +2
+ Misses 338 337 -1
+ Partials 186 185 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
joeyyy09
approved these changes
Aug 27, 2024
This was referenced Aug 27, 2024
yurishkuro
added a commit
that referenced
this pull request
Aug 27, 2024
## Which problem is this PR solving? - Part of #5889 ## Description of the changes - Replace `make echo-version` with two separate v1/v2 targets, using new vars introduced in #5890 - Refactor `scripts/package-deploy.sh` to publish 2.x bundle ## How was this change tested? - `$ TARCMD=gtar bash scripts/package-deploy.sh -d` --------- Signed-off-by: Mend Renovate <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 28, 2024
## Which problem is this PR solving? - Part of jaegertracing#5889 ## Description of the changes - Move semver-from-tag determination from Makefile into `scripts/compute-version.sh` - Move Go build info and Windows build info to dedicated Makefiles - Fixed execute permissions on all scripts ## How was this change tested? - ran windows build and jaeger / query builds to ensure expected behavior --------- Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: Jared Tan <[email protected]>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 28, 2024
## Which problem is this PR solving? - Part of jaegertracing#5889 ## Description of the changes - Replace `make echo-version` with two separate v1/v2 targets, using new vars introduced in jaegertracing#5890 - Refactor `scripts/package-deploy.sh` to publish 2.x bundle ## How was this change tested? - `$ TARCMD=gtar bash scripts/package-deploy.sh -d` --------- Signed-off-by: Mend Renovate <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Jared Tan <[email protected]>
mahadzaryab1
pushed a commit
to mahadzaryab1/jaeger
that referenced
this pull request
Aug 31, 2024
## Which problem is this PR solving? - Part of jaegertracing#5889 ## Description of the changes - Move semver-from-tag determination from Makefile into `scripts/compute-version.sh` - Move Go build info and Windows build info to dedicated Makefiles - Fixed execute permissions on all scripts ## How was this change tested? - ran windows build and jaeger / query builds to ensure expected behavior --------- Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
pushed a commit
to mahadzaryab1/jaeger
that referenced
this pull request
Aug 31, 2024
## Which problem is this PR solving? - Part of jaegertracing#5889 ## Description of the changes - Replace `make echo-version` with two separate v1/v2 targets, using new vars introduced in jaegertracing#5890 - Refactor `scripts/package-deploy.sh` to publish 2.x bundle ## How was this change tested? - `$ TARCMD=gtar bash scripts/package-deploy.sh -d` --------- Signed-off-by: Mend Renovate <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Mahad Zaryab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
scripts/compute-version.shHow was this change tested?