Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Lint Rule: use-any #5510

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

FlamingSaint
Copy link
Member

@FlamingSaint FlamingSaint commented Jun 3, 2024

Which problem is this PR solving?

Description of the changes

  • Enabled use-any in revive linter. Replaced occurrences of interface{} with any

How was this change tested?

  • make lint make test

Checklist

Signed-off-by: FlamingSaint <[email protected]>
@FlamingSaint FlamingSaint requested a review from a team as a code owner June 3, 2024 01:12
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.19%. Comparing base (b38d2f9) to head (d732f5c).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/cassandra/gocql/gocql.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5510      +/-   ##
==========================================
+ Coverage   96.18%   96.19%   +0.01%     
==========================================
  Files         327      327              
  Lines       16012    16012              
==========================================
+ Hits        15401    15403       +2     
+ Misses        436      435       -1     
+ Partials      175      174       -1     
Flag Coverage Δ
badger_v1 8.05% <0.00%> (ø)
badger_v2 1.93% <8.00%> (ø)
cassandra-3.x-v1 16.43% <32.00%> (ø)
cassandra-3.x-v2 1.85% <8.00%> (ø)
cassandra-4.x-v1 16.43% <32.00%> (ø)
cassandra-4.x-v2 1.85% <8.00%> (ø)
elasticsearch-7-v1 18.88% <48.00%> (ø)
elasticsearch-8-v1 19.08% <48.00%> (ø)
elasticsearch-8-v2 19.07% <48.00%> (ø)
grpc_v1 9.47% <8.00%> (-0.02%) ⬇️
grpc_v2 7.53% <8.00%> (ø)
kafka 9.78% <0.00%> (ø)
opensearch-1-v1 18.92% <48.00%> (ø)
opensearch-2-v1 18.92% <48.00%> (-0.02%) ⬇️
opensearch-2-v2 18.92% <48.00%> (-0.02%) ⬇️
unittests 93.89% <91.80%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 3, 2024
@albertteoh albertteoh enabled auto-merge (squash) June 3, 2024 02:28
@yurishkuro yurishkuro merged commit f2b46d4 into jaegertracing:main Jun 3, 2024
41 checks passed
@FlamingSaint FlamingSaint deleted the linter_fix branch June 3, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants