Enable Lint Rules: bare-return & empty-lines #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FlamingSaint <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5512 +/- ##
===========================================
+ Coverage 54.23% 96.19% +41.95%
===========================================
Files 161 327 +166
Lines 8369 16011 +7642
===========================================
+ Hits 4539 15401 +10862
+ Misses 3384 435 -2949
+ Partials 446 175 -271
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Jun 3, 2024
| @@ -149,5 +149,5 @@ func (r *requestDurations) buildTimer(metricsFactory metrics.Factory, key record | |||
| "method": key.method, | |||
| }, | |||
| }) | |||
| return | |||
| return out | |||
There was a problem hiding this comment.
We can remove the name "out" from the signature
There was a problem hiding this comment.
The defer function on top requires the named output as its assigning a value to it
yurishkuro
added
the
changelog:ci
Signed-off-by: FlamingSaint <[email protected]>
Signed-off-by: FlamingSaint <[email protected]>
FlamingSaint
changed the title
yurishkuro
approved these changes
Jun 3, 2024
yurishkuro
approved these changes
Jun 3, 2024
yurishkuro
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
make lintmake testChecklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test