Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage_v1] Add time window to GetTraceRequest #6244

Merged

Conversation

rim99
Copy link
Contributor

@rim99 rim99 commented Nov 23, 2024

Which problem is this PR solving?

Part of #4150

Description of the changes

Add time window for trace get service in storage grpc plugin

How was this change tested?

  • unix test

Checklist

@rim99 rim99 marked this pull request as ready for review November 23, 2024 04:09
@rim99 rim99 requested a review from a team as a code owner November 23, 2024 04:09
@rim99 rim99 requested a review from jkowall November 23, 2024 04:09
@rim99 rim99 force-pushed the add-time-window-storage-grpc-plugin branch from 0d9de23 to 306fd2c Compare November 23, 2024 04:30
@rim99 rim99 force-pushed the add-time-window-storage-grpc-plugin branch from 306fd2c to 975c152 Compare November 23, 2024 14:07
@yurishkuro yurishkuro changed the title enhancement: add time window for trace get service in storage grpc plugin [storage_v1] Add time window to GetTraceRequest Nov 23, 2024
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (c00931f) to head (975c152).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6244      +/-   ##
==========================================
+ Coverage   96.43%   96.46%   +0.02%     
==========================================
  Files         355      355              
  Lines       20161    20149      -12     
==========================================
- Hits        19443    19436       -7     
+ Misses        530      526       -4     
+ Partials      188      187       -1     
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.60% <ø> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.67% <ø> (ø)
elasticsearch-8.x-v1 18.84% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.66% <ø> (ø)
grpc_v1 9.44% <ø> (+<0.01%) ⬆️
grpc_v2 6.98% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.66% <ø> (-0.01%) ⬇️
opensearch-1.x-v1 18.73% <ø> (+<0.01%) ⬆️
opensearch-2.x-v1 18.73% <ø> (+<0.01%) ⬆️
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.37% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yurishkuro yurishkuro merged commit 3f8c2e7 into jaegertracing:main Nov 23, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants