Skip to content

Commit

Permalink
KVM: x86: Break CONFIG_KVM_X86's direct dependency on KVM_INTEL || KV…
Browse files Browse the repository at this point in the history
…M_AMD

Rework CONFIG_KVM_X86's dependency to only check if KVM_INTEL or KVM_AMD
is selected, i.e. not 'n'.  Having KVM_X86 depend directly on the vendor
modules results in KVM_X86 being set to 'm' if at least one of KVM_INTEL
or KVM_AMD is enabled, but neither is 'y', regardless of the value of KVM
itself.

The documentation for def_tristate doesn't explicitly state that this is
the intended behavior, but it does clearly state that the "if" section is
parsed as a dependency, i.e. the behavior is consistent with how tristate
dependencies are handled in general.

  Optionally dependencies for this default value can be added with "if".

Fixes: ea4290d ("KVM: x86: leave kvm.ko out of the build if no vendor module is requested")
Cc: [email protected]
Signed-off-by: Sean Christopherson <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
  • Loading branch information
sean-jc authored and bonzini committed Nov 20, 2024
1 parent 1331343 commit 9ee62c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/kvm/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ menuconfig VIRTUALIZATION
if VIRTUALIZATION

config KVM_X86
def_tristate KVM if KVM_INTEL || KVM_AMD
def_tristate KVM if (KVM_INTEL != n || KVM_AMD != n)
select KVM_COMMON
select KVM_GENERIC_MMU_NOTIFIER
select KVM_ELIDE_TLB_FLUSH_IF_YOUNG
Expand Down

0 comments on commit 9ee62c3

Please sign in to comment.