Removed luminal_symbolic

jafioti · May 1, 2024 · 2845324 · 2845324
1 parent a29319e
commit 2845324
Show file tree

Hide file tree

Showing 10 changed files with 196 additions and 219 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -6,7 +6,6 @@ description = "Deep learning at the speed of light."
 license = "MIT OR Apache-2.0"
 
 [dependencies]
-luminal_symbolic = {path="./crates/luminal_symbolic"}
 itertools = "0.11.0"
 num-traits = "0.2.16"
 petgraph = "0.6.4"
@@ -32,7 +31,6 @@ members = [
     "crates/luminal_cpu",
     "crates/luminal_nn",
     "crates/luminal_training",
-    "crates/luminal_symbolic",
 ]
 exclude = [
     "crates/luminal_metal",

diff --git a/crates/luminal_symbolic/Cargo.toml b/crates/luminal_symbolic/Cargo.toml
diff --git a/crates/luminal_symbolic/src/lib.rs b/crates/luminal_symbolic/src/lib.rs
diff --git a/crates/luminal_symbolic/src/simplify.rs b/crates/luminal_symbolic/src/simplify.rs
diff --git a/crates/luminal_symbolic/src/term.rs b/crates/luminal_symbolic/src/term.rs
diff --git a/crates/luminal_symbolic/src/tests.rs b/crates/luminal_symbolic/src/tests.rs
diff --git a/crates/luminal_training/src/optimizer.rs b/crates/luminal_training/src/optimizer.rs
@@ -39,7 +39,7 @@ pub fn sgd(
 /// Output: (New weight outputs, Learning Rate Tensor)
 pub fn sgd_on_graph(
     graph: &mut Graph,
-    old_weights: &impl ToIds,
+    old_weights: impl ToIds,
     grads: &[(NodeIndex, ShapeTracker)],
 ) -> (Vec<NodeIndex>, GraphTensor<()>) {
     let lr = graph.named_tensor("Learning Rate").set(3e-4).keep(); // Karpathy constant

diff --git a/src/lib.rs b/src/lib.rs
@@ -19,7 +19,6 @@ pub mod prelude {
     pub use crate::op::*;
     pub use crate::shape::*;
     pub use half::{bf16, f16};
-    pub use luminal_symbolic::*;
     pub use petgraph;
     pub use petgraph::stable_graph::NodeIndex;
     pub use tinyvec;

diff --git a/src/shape/mod.rs b/src/shape/mod.rs
@@ -3,17 +3,17 @@ mod broadcast;
 mod permute;
 mod realize;
 mod slice;
+mod symbolic;
 pub mod tracker;
 
 pub use axes::*;
 pub use broadcast::*;
 pub use permute::*;
 pub use realize::*;
 pub use slice::*;
+pub use symbolic::*;
 pub use tracker::*;
 
-use crate::prelude::*;
-
 // This currently is a lot more complicated than it needs to be. Can it be simplified?
 
 /// Represents a single dimension of a multi dimensional [Shape]