Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding capability to deploy using Docker. #1525

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/create-docker-image.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Build MusicBot Docker Image

on:
workflow_dispatch:
inputs:
musicbot_version:
description: 'Jagrosh/MusicBot version (required) Ex-0.3.9'
required: true
default: '0.3.9'

jobs:
Build-Push-Docker-Image:
runs-on: ubuntu-latest
env:
musicbot_version: ${{ github.event.inputs.musicbot_version }}

steps:
- name: Checkout Repository
uses: actions/checkout@v3

- name: Building Docker Image
run: |
echo ${musicbot_version}
docker build --build-arg MUSICBOT_VERSION=${musicbot_version} -t ${{ secrets.DOCKER_USERNAME }}/jmusicbot:${musicbot_version} .

- name: Log in to Docker Hub
env:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
run: |
echo $DOCKER_PASSWORD | docker login -u $DOCKER_USERNAME --password-stdin

- name: Pushing Docker Image to Docker Hub
run: docker push ${{ secrets.DOCKER_USERNAME }}/jmusicbot:${musicbot_version}
22 changes: 22 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
FROM amazoncorretto:11-al2023

ARG MUSICBOT_VERSION

WORKDIR /

RUN pwd
RUN ls -lrt

ENV TOKEN harsh

RUN echo "Building MusicBot version: $MUSICBOT_VERSION"

# Download and rename the JAR file based on the provided version
RUN curl -LJO "https://github.com/jagrosh/MusicBot/releases/download/$MUSICBOT_VERSION/JMusicBot-$MUSICBOT_VERSION.jar" \
&& mv "JMusicBot-$MUSICBOT_VERSION.jar" JMusicBot.jar
Comment on lines +15 to +16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be preferred to use the build artifacts from the previous job instead of fetching the release file like this. The files attached on a release are not necessarily the same as builds from source code.

Tip: with curl the mv step is also completely unnecessary since you can also save the file as a specified filename

Suggested change
RUN curl -LJO "https://github.com/jagrosh/MusicBot/releases/download/$MUSICBOT_VERSION/JMusicBot-$MUSICBOT_VERSION.jar" \
&& mv "JMusicBot-$MUSICBOT_VERSION.jar" JMusicBot.jar
RUN curl -o JMusicBot.jar -LJ "https://github.com/jagrosh/MusicBot/releases/download/$MUSICBOT_VERSION/JMusicBot-$MUSICBOT_VERSION.jar"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jogerj

Can you please help me with the change required to get the build form Artificats, I found this way more easier and understandable.


# Copying Repo config.txt file to Build
COPY config.txt /config.txt

# Replace occurrences of ${BOT-TOKEN} with the value of TOKEN in config.txt during runtime
CMD ["sh", "-c", "sed -i 's/${BOT-TOKEN}/${TOKEN}/g' /config.txt && java -Dnogui=true -jar /JMusicBot.jar"]
13 changes: 13 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
version: "3"
services:
discord-bot:
container_name: Discord-Hr-Music-bot
restart: unless-stopped
# Modify Version as per input[0.3.9]
image: [DOCKER HUB USER]/jmusic:[version]
labels:
# This is for Watchtower to Ignore Updating this Image.
- "com.centurylinklabs.watchtower.enable=false"
environment:
# Add your Bot TOken below
- TOKEN=[BOT TOKEN]