Add config option whether the bot should deafen itself

[MichailiK]

This pull request...

• Fixes a bug
• Introduces a new feature
• Improves an existing feature
• Boosts code quality or performance

Description

Adds a config option which allows users to configure whether the bot should deafen itself or not.

Purpose

Although it is better for the bot to be deafened due to network bandwidth savings & increased privacy, some people are annoyed by the deafened icon and would prefer to disable deafen.

Relevant Issue(s)

N/A, i remember there were a few complaints about this on the Discord server.

[jagrosh]

This looks good in terms of code. However:

1. Since we know we are working on attenuation, we need to make sure that when we do that we add a note to this feature's config description.
2. Do we have hard evidence that deafening actually reduces network load? At the time that JMusicBot was originally written, deafening was purely visual and didn't actually prevent receiving voice data (bots would still get it and could still 'record' audio while deafened, and the official Discord client effectively just silenced incoming audio). I hope this has changed, but is there an actual test anywhere proving that it has?

(note that I'm in favor of this change regardless of how we handle deafening; I just still haven't seen any hard evidence that it is anything more than a visual change)

[MichailiK]

1. Mmh, the issue with attenuation is there seems to be a JDA 4 bug that only fires the speaking event once, then never again, so it cannot be implemented atm, at least without upgrading to JDA 5 im guessing.
2. Somewhat of a rant incoming:

You know, it would be awesome if the response of Discord's support team were correct:

Hello,

thank you for your patience.

To answer your question: Yes, it has an impact and helps us save bandwidth in voice channels.

Unfortunately, we cannot provide you with any more information. But please let us know if you have any further questions about the app! :)

Well, unfortunately, it looks like that's not actually the case & deafening yourself is not enough. You'll have to server deafen in order to not receive any traffic:

discord.deafen.as.a.bot.mp4

(Notice how Network rx goes up as I speak, until i server deafen the bot)

That is... a pretty disappointing discovery how the support rep has blundered & actually only server deafening saves bandwidth...

[MichailiK]

"Superseded" by #1551 following this discovery.