Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add library flag for all ns filtering #164

Merged
merged 2 commits into from
Sep 28, 2024
Merged

feat: add library flag for all ns filtering #164

merged 2 commits into from
Sep 28, 2024

Conversation

jahvon
Copy link
Owner

@jahvon jahvon commented Sep 28, 2024

Summary

By default only show executables in the root namespace with options to show all namespaces. Includes improvements for ref displays in the library view.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 9.80392% with 46 lines in your changes missing coverage. Please review.

Project coverage is 36.17%. Comparing base (29daebf) to head (2854f5f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/internal/library.go 11.11% 16 Missing ⚠️
types/executable/ref.go 0.00% 9 Missing ⚠️
internal/io/library/styles.go 0.00% 7 Missing ⚠️
internal/io/library/view.go 0.00% 6 Missing ⚠️
tests/utils/sub_execs.go 0.00% 4 Missing ⚠️
internal/io/library/init.go 0.00% 3 Missing ⚠️
types/executable/executable.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   36.41%   36.17%   -0.24%     
==========================================
  Files          81       81              
  Lines        5682     5705      +23     
==========================================
- Hits         2069     2064       -5     
- Misses       3207     3236      +29     
+ Partials      406      405       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahvon jahvon merged commit 3ce010d into main Sep 28, 2024
5 checks passed
@jahvon jahvon deleted the library-filters branch September 28, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant