Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add key-value store for sharing data across executables #187

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

jahvon
Copy link
Owner

@jahvon jahvon commented Oct 23, 2024

Includes the addition of a flow store subcommands that can be called within shell executables to set/get data that may be set within other executables.

Be default, the commands when called outside of an executable will store values into a "root bucket" whose values are accessible in all executables. When running serial or parallel exec, a separate temporary bucket is created for sharing data across that execution run.

This is still experimental; docs updates to come

@jahvon jahvon added this to the v0.7.0 milestone Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 58.09524% with 88 lines in your changes missing coverage. Please review.

Project coverage is 35.36%. Comparing base (fd5bbc7) to head (0ceabdc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/internal/store.go 55.35% 40 Missing and 10 partials ⚠️
internal/services/store/store.go 65.88% 20 Missing and 9 partials ⚠️
cmd/internal/exec.go 25.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   34.64%   35.36%   +0.71%     
==========================================
  Files          81       83       +2     
  Lines        6742     6956     +214     
==========================================
+ Hits         2336     2460     +124     
- Misses       3968     4039      +71     
- Partials      438      457      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahvon jahvon marked this pull request as ready for review October 30, 2024 02:23
@jahvon jahvon merged commit a07f0bc into main Oct 30, 2024
10 checks passed
@jahvon jahvon deleted the store branch October 30, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant