Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move shared retry and concurrency handling #195

Merged
merged 2 commits into from
Nov 17, 2024
Merged

refactor: move shared retry and concurrency handling #195

merged 2 commits into from
Nov 17, 2024

Conversation

jahvon
Copy link
Owner

@jahvon jahvon commented Nov 17, 2024

Simplify the serial and parallel runners by moving retry handling and work scheduling into the engine package. This includes updates to the runner function signatures and executable runner tests

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 74.86339% with 46 lines in your changes missing coverage. Please review.

Project coverage is 37.50%. Comparing base (6f324a0) to head (27f9df8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/runner/engine/engine.go 77.88% 23 Missing ⚠️
internal/runner/serial/serial.go 42.10% 9 Missing and 2 partials ⚠️
internal/runner/parallel/parallel.go 70.58% 3 Missing and 2 partials ⚠️
internal/runner/engine/retry/retry.go 90.90% 2 Missing and 1 partial ⚠️
cmd/internal/exec.go 50.00% 0 Missing and 1 partial ⚠️
internal/runner/launch/launch.go 0.00% 1 Missing ⚠️
internal/runner/render/render.go 0.00% 1 Missing ⚠️
internal/templates/templates.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   35.39%   37.50%   +2.10%     
==========================================
  Files          76       76              
  Lines        6619     6348     -271     
==========================================
+ Hits         2343     2381      +38     
+ Misses       3840     3534     -306     
+ Partials      436      433       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahvon jahvon merged commit 4ab1e10 into main Nov 17, 2024
10 checks passed
@jahvon jahvon deleted the engine branch November 17, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant