Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve how buckets are managed in the store #196

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Conversation

jahvon
Copy link
Owner

@jahvon jahvon commented Nov 17, 2024

Various refactors/fixes that aims to make working with the store cleaner

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 54.70085% with 53 lines in your changes missing coverage. Please review.

Project coverage is 37.50%. Comparing base (4ab1e10) to head (b2ea4ab).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/services/store/store.go 61.11% 26 Missing and 9 partials ⚠️
cmd/internal/store.go 35.00% 8 Missing and 5 partials ⚠️
cmd/internal/exec.go 28.57% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   37.47%   37.50%   +0.02%     
==========================================
  Files          76       76              
  Lines        6348     6415      +67     
==========================================
+ Hits         2379     2406      +27     
- Misses       3535     3562      +27     
- Partials      434      447      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahvon jahvon merged commit 1a71adf into main Nov 17, 2024
10 checks passed
@jahvon jahvon deleted the store-fixes branch November 17, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant