Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip!: use expr language for executable templates #204

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

jahvon
Copy link
Owner

@jahvon jahvon commented Dec 27, 2024

Replace Sprig and standard Go templating funcs with Expr lang to align with usage in ref config conditionals

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 78.53659% with 44 lines in your changes missing coverage. Please review.

Project coverage is 38.63%. Comparing base (ee5d737) to head (1267582).

Files with missing lines Patch % Lines
internal/services/expr/template.go 79.25% 22 Missing and 6 partials ⚠️
internal/templates/templates.go 75.00% 3 Missing and 3 partials ⚠️
internal/services/expr/expr.go 50.00% 3 Missing ⚠️
internal/services/rest/rest.go 75.00% 3 Missing ⚠️
internal/templates/artifacts.go 50.00% 3 Missing ⚠️
internal/templates/expression.go 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   37.37%   38.63%   +1.25%     
==========================================
  Files          77       79       +2     
  Lines        6579     6714     +135     
==========================================
+ Hits         2459     2594     +135     
+ Misses       3649     3643       -6     
- Partials      471      477       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant