-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for InvocationContext.getInterceptorBindings() #479
Add tests for InvocationContext.getInterceptorBindings() #479
Conversation
c34f1fb
to
7e98a47
Compare
8ebed4d
to
0a0ea5c
Compare
This would be ready now, I believe, but let's keep it as a draft until jakartaee/interceptors#103 is merged. |
Moved from draft to ready for review as the linked PR was already approved. |
0a0ea5c
to
5337b72
Compare
5337b72
to
11a3250
Compare
I just realized we didn't add a test for interceptor bindings added through |
Ok, I'll make a note and send a PR |
I think this also doesn't test:
I can make a PR for the second one, and I'd be happy to do the first one as well if we can determine the correct behaviour. |
True, although there is little chance this wouldn't work assuming the interceptor itself is bound correctly (i.e. if that binding was registered, I'd be very surprised if it weren't visible here)
Good point and those should be returned as well because of the javadoc wording of the method:
👍 |
TCK tests for jakartaee/interceptors#99
Draft because there's a temporary profile to enable using Jakarta staging repository. Once Interceptors 2.2.0-RC1 hits Maven Central, I'll remove that and this PR will be ready.