Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert incorrect change in ambiguity resolution #772

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Feb 26, 2024

We previously [1] changed wording in the ambiguity resolution specification from

Return an Iterator, that iterates over the set of contextual references
for the resulting beans and required type, as defined in <<contextual_reference>>.

to

Return an Iterator, that iterates over the set of contextual references
for the resulting beans, as defined in <<contextual_reference>>.

This was an attempt to simplify the text, but is in fact incorrect, because a contextual reference is always determined by the bean and the bean type.

This commit reverts to the previous wording.

[1] 74827d2

We previously [1] changed wording in the ambiguity resolution specification from

> Return an `Iterator`, that iterates over the set of contextual references
> for the resulting beans and required type, as defined in <<contextual_reference>>.

to

> Return an `Iterator`, that iterates over the set of contextual references
> for the resulting beans, as defined in <<contextual_reference>>.

This was an attempt to simplify the text, but is in fact incorrect, because
a contextual reference is always determined by the bean and the bean type.

This commit reverts to the previous wording.

[1] jakartaee@74827d2
@Ladicek Ladicek added this to the CDI 4.1 milestone Feb 26, 2024
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I do recall we had that discussion about contextual references but I didn't recall we did this change earlier.

@manovotn manovotn merged commit d9f95b4 into jakartaee:main Feb 26, 2024
5 checks passed
@Ladicek Ladicek deleted the fix-ambiguity-resolution branch February 27, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants