Move override annotations to inner classes of @ConfigMapping #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radcortez
commented
May 22, 2024
| @Documented | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Target({ ElementType.METHOD }) | ||
| @interface Default { |
There was a problem hiding this comment.
I'm wondering if we should provide specialized Default types like @DefaultInt, @DefaultBoolean, etc, or as a member intValue(), booleanValue(). The annotation / member to use has to match the declared type. If another annotation / member is used we could throw a validation error.
This would avoid having to come up with a Conversion strategy from String to something and provide type safety for defaults definition
There was a problem hiding this comment.
One cannot create an extra annotation for each java Type. Rather, the Default value can be a class of data converter. While we have not discussed the converters yet, it looks like it should be discussed before continuing with the @Default annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.