fix: Prevent last nav menu from overflowing #1727
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jakartaee ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for jakartaee ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
oliviergoulet5
commented
Sep 29, 2023
| // Prevent menu from overflowing on the right side of the screen. The reason we | ||
| // are selecting the 2nd last child is because the last child is a mobile-only | ||
| // menu item. | ||
| #main-menu .navbar-nav li.dropdown:nth-last-child(2) { |
There was a problem hiding this comment.
It might seem a bit hacky. I wanted to add a custom parameter to the menu item in menu.toml. Something like class or direction. However, Hugo doesn't allow params on menu items, only menus.
I also tried doing :last-of-type, but that selector only works with elements, not classes. That would've been perfect if it worked because I would select the last .dropdown.
Bootstrap introduced responsive menu direction classes in v4. When we migrate to v5, we could have a better solution using that.
oliviergoulet5
requested review from
ericpoirier,
chrisguindon,
autumnfound and
ZacharySabourin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1726