Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 680 and also Ignore the challenged test #757

Merged

Conversation

pmd1nh
Copy link

@pmd1nh pmd1nh commented Nov 11, 2024

Revert #680 in 6.1.x.
Also @Ignore the challenged test.

@pmd1nh pmd1nh self-assigned this Nov 11, 2024
@pmd1nh pmd1nh force-pushed the Revert_PR_680_and_Ignore_FlushBufferTest branch 2 times, most recently from c1f8014 to a52dcd3 Compare November 11, 2024 01:09
@pmd1nh pmd1nh force-pushed the Revert_PR_680_and_Ignore_FlushBufferTest branch from a52dcd3 to 1f130b5 Compare November 11, 2024 01:10
@pmd1nh
Copy link
Author

pmd1nh commented Nov 11, 2024

@Ignore is not available, using @Disabled instead

@pmd1nh
Copy link
Author

pmd1nh commented Nov 14, 2024

@markt-asf Can you please review? Thanks!

@pnicolucci
Copy link
Contributor

@pnicolucci pnicolucci self-requested a review November 14, 2024 15:55
Copy link
Contributor

@markt-asf markt-asf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM. The TCK-Exclude-List.txt file does need to be updated.

@pmd1nh
Copy link
Author

pmd1nh commented Nov 15, 2024

The code changes LGTM. The TCK-Exclude-List.txt file does need to be updated.

Updated

@pmd1nh pmd1nh removed the request for review from olamy November 15, 2024 16:05
@markt-asf markt-asf merged commit 19e73ad into jakartaee:6.1.x Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants