svgo-worker/index.js: be stricter with the checks

SVGO returns `undefined` when an attribute isn't present, not `null`.
jakearchibald · Oct 18, 2021 · b925d7a · b925d7a
1 parent 20e5474
commit b925d7a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -57,14 +57,6 @@
     "rules": {
       "arrow-body-style": "off",
       "capitalized-comments": "off",
-      "eqeqeq": [
-        "error",
-        "always",
-        {
-          "null": "ignore"
-        }
-      ],
-      "no-eq-null": "off",
       "no-multi-assign": "off",
       "no-negated-condition": "off",
       "no-shadow": "error",

diff --git a/src/js/svgo-worker/index.js b/src/js/svgo-worker/index.js
@@ -11,10 +11,13 @@ const createDimensionsExtractor = () => {
           // Node, parentNode
           enter: ({ name, attributes }, { type }) => {
             if (name === 'svg' && type === 'root') {
-              if (attributes.width != null && attributes.height !== null) {
+              if (
+                attributes.width !== undefined &&
+                attributes.height !== undefined
+              ) {
                 dimensions.width = Number.parseFloat(attributes.width);
                 dimensions.height = Number.parseFloat(attributes.height);
-              } else if (attributes.viewBox != null) {
+              } else if (attributes.viewBox !== undefined) {
                 const viewBox = attributes.viewBox.split(/,\s*|\s+/);
                 dimensions.width = Number.parseFloat(viewBox[2]);
                 dimensions.height = Number.parseFloat(viewBox[3]);