Refactor product update to replace locations instead of concatenating

jamalsoueidan · May 30, 2024 · 26af379 · 26af379
1 parent 4f99e73
commit 26af379
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/src/functions/customer/services/product/update.ts b/src/functions/customer/services/product/update.ts
@@ -25,14 +25,7 @@ export const CustomerProductServiceUpdate = async (
       productId,
     });
 
-  const locations = oldProduct.locations.concat(
-    (body.locations || [])?.filter(
-      (item2) =>
-        !oldProduct.locations.some(
-          (item1) => item1.location.toString() === item2.location.toString() // must use toString since location could be type of objectId
-        )
-    )
-  );
+  const locations = !body.locations ? oldProduct.locations : body.locations;
 
   const newProduct = {
     ...oldProduct,