Reject old JWT tokens #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested working as described above. |
|
I see. Currently, when we issue a token it has an expiration and can be used until that time. This seems like a feature request to invalidate any current, valid token when a new token is generated? If so, I don't think we need this in our repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue - where a previous token could be used for login.
How to reproduce:
/v1/login-> token A/v1/Users/me/v1/loginagain/v1/Users/mewith token AExpected: the token A is no longer valid - since there is a newer one. Only one active token should be allowed
Actual: You can login with all the tokens as long as there is a valid one in redis