Accept ArrayBufferLike in deserialize

james-pre · Nov 28, 2024 · b0275a5 · b0275a5
1 parent 589e582
commit b0275a5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/struct.ts b/src/struct.ts
@@ -127,13 +127,13 @@ export function serialize(instance: unknown): Uint8Array {
 /**
  * Deserializes a struct from a Uint8Array
  */
-export function deserialize(instance: unknown, _buffer: ArrayBuffer | ArrayBufferView) {
+export function deserialize(instance: unknown, _buffer: ArrayBufferLike | ArrayBufferView) {
 	checkInstance(instance);
 	const { options, members } = instance.constructor[symbol_metadata(instance.constructor)][Symbol.struct_metadata];
 
 	const buffer = _buffer instanceof Uint8Array ? _buffer : new Uint8Array('buffer' in _buffer ? _buffer.buffer : _buffer);
 
-	const view = new DataView(buffer.buffer.slice(buffer.byteOffset, buffer.byteOffset + buffer.byteLength));
+	const view = new DataView(buffer.buffer, buffer.byteOffset, buffer.byteOffset + buffer.byteLength);
 
 	for (const [name, { type, offset, length }] of members) {
 		for (let i = 0; i < (length || 1); i++) {