-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fortran object oriented support #239
base: master
Are you sure you want to change the base?
Conversation
8b37c8e
to
e08b476
Compare
e08b476
to
6cca85a
Compare
@jameskermode I'm not sure what is wrong with the builds, could you help me figure out? |
6cca85a
to
1b752d4
Compare
@danbeibei this looks great! Looks like we did some work in parallel in #233 and #236 in the last week (what a coincidence). Does this already allow also allocatable output of polymorphic class instances in factory procedures? If yes, did you follow the same strategy of wrapping a class into another type container? It would be great if we could cross-check our example cases in the each others branch and then see how to proceed with merging. |
Hi @krystophny, great stuff! No, it does not allow allocatable output. I have rapidly checked out the examples in your branch and can confirm my changes do not actually address what you changes do. I'll take the time in a few weeks to have a look into the code you pushed. |
@danbeibei @jameskermode I have now summarized all PRs on #240 in order, rebased mine on top of this one here, and merged everything in master of https://github.com/itpplasma/f90wrap for testing until you can dig through the reviews. Until then, happy holidays! |
@@ -13,7 +13,7 @@ description = "Fortran to Python interface generator with derived type support" | |||
authors = [{name = "James Kermode", email = "[email protected]"}] | |||
python-requires = ">=3.8" | |||
urls = {Homepage = "https://github.com/jameskermode/f90wrap"} | |||
dependencies = ["numpy>=1.13", "packaging"] | |||
dependencies = ["numpy>=1.13", "packaging", "pytest", "pytest-dependency"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions here:
- Should
pytest-dependency
really be used? Avoiding dependencies between tests is usually considered good practice. - If 1) can be avoided, is
pytest
even necessary, or better stick to good oldunittest
(I rewrote my tests after realizing thatpytest
has not been a requirement up to now)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would indeed prefer to stick to unittest and avoid adding dependencies if possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge this if the pytest dependency can be removed
This PR sits on top of #230, #231, #232, #237 and #238
It adds partial support for Fortran object oriented syntax
Support for:
abstract
fortran keyworddeferred
fortran keywordNo support for:
non_overridable
fortran keywordpass
/nopass
fortran keywords