Support for "dark mode" and custom page title in html logger #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/core to 2.11.8, webpack to 5.98.0, and related devDependencies
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tests/html/test3.html
Fixed
| var tooltipTriggerList = [].slice.call( | ||
| document.querySelectorAll('[data-toggle="tooltip"]') | ||
| ); | ||
| var tooltipList = tooltipTriggerList.map(function (tooltipTriggerEl) { |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note test
tests/html/test3.html
Fixed
| }); | ||
| check_age(); | ||
| setTimeout(too_old, (30 * 2000)); | ||
| update_props = { |
Check warning
Code scanning / CodeQL
Missing variable declaration Warning test
|
This is awesome, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new features:
1/ The page title can be configured using a new
navbar_titleconfiguration line. The default if not set is "SimpleMonitor", which matches previous behaviour. The screenshot below is an example withnavbar_title=Network Dashboard.2/ The page can be configured to display with a dark theme using a new
visual_themeconfiguration line. The default if not set is "light", which matches previous behaviour. The screenshot below is an example withvisual_theme=dark.The different themes are provided by Bootstrap 5.3, and this PR includes updating bootstrap to 5.3.3 for that. The PR also version bumps the other frontend dependencies too.
For
mapoutput, the page navbar and page background below the map support dark theme, however the map picture (the map tiles) remain in their original colours.