Change to use asyncio rather than threading #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whi-tw
force-pushed
the
migrate_to_asyncio
branch
4 times, most recently
from
c4e830c to
e21145e
Compare
This allows event-driven things to be far more easily driven (ie. pulsectl) Also, Rather than defining a source / sync for the mute buttons, use the current default one - how often do you need to immediately mute a device that's not in use?
whi-tw
force-pushed
the
migrate_to_asyncio
branch
from
e21145e to
42e2451
Compare
|
I think both of these changes make sense. I was also thinking of using asyncio for the keylight deck so the buttons can show current state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows event-driven things to be far more easily driven
(ie. pulsectl)
Also, Rather than defining a source / sync for the mute buttons,
use the current default one - how often do you need to immediately mute
a device that's not in use?
Also, bump python version to
3.10.0to enable sweet sweetmatch casestatements