Test elev.R #17
Merged
Test elev.R #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Programming best practice is to avoid using bare numbers, and instead to use variables – that way it is clear where values come from and their relationship to the underlying objects. Where values are changed, it can be easy to miss a hard-coded number (as 1728 here), or to calculate its correct value by hand.
Masks write to console
Handles progress bars
|
I am not sure why we are receiving an error when unzipping srtm files (see the testthat results for elev). |
now uncalled
Inreased robustness to file permission errors
Names are names of temporary files created by rast (I think)
|
Closed with unmerged commits. |
|
Sorry – must have misread a notification – it looked like GitHub had told me it was merged. Glad you could restore! |
|
No dramas! I'm totally digging how these processes work. Thanks a bunch for showing me the ropes! Honestly, I hadn't even used these features in my previous package, and now I've got a bunch of changes in mind based on what I've learned here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for
elev(e_source = "geodata").Modifications to
elev.R:locationusingas(, "sf")elevation_3s()Next, I'll try using
e_source = "mapzen", which I can't get to work at the moment. It looks likeelevatr::get_elev_raster()relies onrgdal, which is being deprecated as part of thesfupdate.[edit] - I see that you are already aware of this issue... I'll incorporate a dependency on the beta version of
elevatr.