Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FileSharePasswordView #40

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Update FileSharePasswordView #40

merged 6 commits into from
Jan 30, 2025

Conversation

BIG-RAT
Copy link
Contributor

@BIG-RAT BIG-RAT commented Oct 29, 2024

Display the read/write account when prompting for the password of a file share.

@BIG-RAT BIG-RAT requested a review from a team as a code owner October 29, 2024 15:29
JamfSync/UI/FileSharePasswordView.swift Show resolved Hide resolved
JamfSync/UI/FileSharePasswordView.swift Outdated Show resolved Hide resolved
JamfSync/UI/FileSharePasswordView.swift Outdated Show resolved Hide resolved
JamfSync/UI/FileSharePasswordView.swift Outdated Show resolved Hide resolved
JamfSync/UI/FileSharePasswordView.swift Outdated Show resolved Hide resolved
JamfSync/UI/FileSharePasswordView.swift Outdated Show resolved Hide resolved
JamfSync/UI/FileSharePasswordView.swift Outdated Show resolved Hide resolved
JamfSync/UI/FileSharePasswordView.swift Outdated Show resolved Hide resolved
JamfSync/UI/FileSharePasswordView.swift Outdated Show resolved Hide resolved
JamfSync/UI/FileSharePasswordView.swift Outdated Show resolved Hide resolved
BIG-RAT and others added 4 commits January 29, 2025 03:04
This seemed like it wasn't quite done how forms are meant to be used and it made it look a lot less consistent to other things as well. I also changed the names from "password" to "credentials" since it's more than just the password now.
Copy link
Contributor

@HarryStrandJamf HarryStrandJamf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at this more, I don't know if this whole change makes sense or not. The username is stored in Jamf Pro, so if it changes, it will be changed back again the next time data is loaded. So if the username is incorrect, it should be corrected in Jamf Pro and not here.

@HarryStrandJamf
Copy link
Contributor

After talking with Leslie about the purpose of this, he said it was because there were folks having issues because they had/wanted individual accounts set up to access the share. Perhaps because of auditing requirements. We decided to make it work as follows: It starts by looking for a keychain entry for the username provided by Jamf Pro, and if that fails, then it checks to see if there is a username saved in the user defaults, and if so, then it will look for a keychain entry there. If so, then it loads and all is well. Otherwise, it will display the dialog along with whatever username it tried last. Once it successfully mounts the file share, then it saves the last username used to the user defaults. So next time it shouldn’t require that the password is entered.

Copy link
Contributor Author

@BIG-RAT BIG-RAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@HarryStrandJamf HarryStrandJamf merged commit ea61839 into main Jan 30, 2025
@HarryStrandJamf HarryStrandJamf deleted the FileSharePasswordView branch January 30, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants