More granular settings #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can now separately allow deletion of files, of files and packages, either manually or after synchronizations. It will also give appropriate warnings depending on whether the desired settings can be respected based on whether packages must also be deleted in order to delete files. Also, it won't give options that don't make sense for that distribution point type or options selected in settings.
team-adder
bot
requested review from
BIG-RAT,
KapnKerk,
mjKosmic and
rydgecrakerjamf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this quite a bit and everything works as expected. This allows more granularity with the settings so you can control whether people are able to delete files at all, either manually or after a synchronization completes, or whether the user is allowed to choose to only delete the files but not the associated package records, or both.