Fix primitive value #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix reset
fix reset button
Error with the chaining syntax that prevents running the build.
Fix chaining syntax
Update manifest.json
fix service worker
update dependencies
Fix/invariant violation dom element
Updated getBookURL function to return a Promise<string>. Updated fetchBook function to handle asynchronous nature of getBookURL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated getBookURL function to return a Promise:
Previously, the getBookURL function returned a primitive string value. This caused issues when used with the await keyword, as await expects a Promise. The function has been modified to return a Promise, resolving with the constructed book URL or rejecting with an error message if the URL is not found.
Updated fetchBook function to handle asynchronous nature of getBookURL:
Changed the call to getBookURL within fetchBook to use await to correctly handle the returned Promise. This ensures that the asynchronous URL retrieval is handled properly, allowing the rest of the function to operate on the resolved string value.
Motivation / Context
Ensures proper handling of asynchronous operations in the fetchBook function, preventing runtime errors related to incorrect usage of await.
Improves code reliability and correctness when fetching book URLs, enhancing the overall stability of the application.
Testing Instructions / How This Has Been Tested
Installed webpack, ran the build and tested it on ProQuest eBook