Skip to content

Commit

Permalink
improved spanish translation with adrocampo's review
Browse files Browse the repository at this point in the history
  • Loading branch information
@JFernando122
JFernando122 committed Jun 22, 2021
1 parent fa03a9e commit 1138c86
Showing 1 changed file with 90 additions and 90 deletions.
Loading

3 comments on commit 1138c86

@adocampo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked several typos and one incorrect translation. I also noticed there are some untranslated sentences remaining.

@JFernando122
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks i will fix them now, but could you tell me where are some of the untranslated sentences? i'm pretty sure i have translated all, i did a search for "" and found none left, i also saw that you suggested some translations even exactly as i wrote them (literally did a copy paste and had no changes)

image

Here is an example where the translation isn't on the reviewed part but one line below and is the same as the sugestion

@adocampo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it was my fault, I didn't notice I had to expand the code block to see they were already translated, so in both cases, "missing" translations and suggesting the same you already translated, it was because I'm an idiot and I didn't expand the code block... 🤦‍♂️
image

Please sign in to comment.