fix janet_string_equalconst #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check string length before pointer equality, so that a string is not considered equal to a prefix slice of itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check string length before pointer equality, so that a string is not considered equal to a prefix slice of itself.
I ran into this with a pretty gnarly bug where e.g.
(symbol/slice 'abcdefg 0 3)returned'abcdefgwhen the symcache was filled just so -- they hash differently, but if you get unlucky enough and there's a hash collision, the resolution runsjanet_string_equalconstand erroneously says "oh yeah we found it" becausecfun_symbol_slicejust changes thelen.