Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix Download location of Nitro TensorRT on Windows #3491

Closed
Van-QA opened this issue Aug 28, 2024 · 9 comments
Closed

bug: Fix Download location of Nitro TensorRT on Windows #3491

Van-QA opened this issue Aug 28, 2024 · 9 comments
Assignees
Labels
os: linux Linux issues type: bug Something isn't working

Comments

@Van-QA
Copy link
Contributor

Van-QA commented Aug 28, 2024

Describe the bug
The installation is not working, there is a toast msg, but users are blocked from getting to the installed status on Jan UI

Screenshots
image

image

image

Additionally, there is an issue with system monitor in linux, that was resolved via 0.5.3
image

@Van-QA Van-QA added the type: bug Something isn't working label Aug 28, 2024
@imtuyethan imtuyethan moved this to Scheduled in Menlo Aug 30, 2024
@louis-menlo
Copy link
Contributor

System monitor issue is addressed. #3492

@freelerobot freelerobot added the os: linux Linux issues label Sep 5, 2024
@imtuyethan imtuyethan moved this from Scheduled to In Review in Menlo Sep 18, 2024
@imtuyethan imtuyethan self-assigned this Sep 18, 2024
@imtuyethan imtuyethan modified the milestones: v0.5.5, v0.5.4 Sep 18, 2024
@imtuyethan imtuyethan moved this from In Review to Need Investigation in Menlo Sep 18, 2024
@imtuyethan
Copy link
Contributor

What installation is this? How can I reproduce?

@imtuyethan imtuyethan removed their assignment Sep 18, 2024
@imtuyethan imtuyethan removed this from the v0.5.5 milestone Sep 18, 2024
@louis-menlo
Copy link
Contributor

@imtuyethan TensorrtLLM requires the CUDA Toolkit to be installed, but some users may not have it set up.

Try to uninstall Cuda Toolkit, try to load a model -> Failed -> there will be a guidance message to lead you to the installation page.

@louis-menlo
Copy link
Contributor

Root cause:

The Tensorrt-llm on Jan is broken, as the engine repository name was changed from nitro-tensorrt-llm to cortex.tensorrt-llm.

Jan Tensort-LLM extension is downloading artifact from the repository releases. Now it's pointing to an incorrect repository.

@louis-menlo
Copy link
Contributor

The Linux release artifact has also been removed from the engine repository. It's likely will be a part of #3690.

@dan-menlo
Copy link
Contributor

dan-menlo commented Sep 27, 2024

@louis-jan Is there a quick fix for this that will allow us to keep legacy TensorRT-LLM extension working in Sprint 21?

  • Cortex team will be working on TensorRT-LLM in Sprint 23 or 24 (i.e. early November)
  • I would just try to keep things working, but if not possible we can also just let it fail for now

@louis-menlo
Copy link
Contributor

Hi @dan-homebrew We can do a quick fix for Windows; it's simply a matter of replacing the URL.

But I'm not sure how Linux is enabled, since we haven't supported it in the extension yet. I'll look into it.

@dan-menlo
Copy link
Contributor

@louis-jan Linux is out of scope - let's just do a quick fix for Windows, and ship it as part of 0.5.5

@louis-menlo
Copy link
Contributor

@louis-jan Linux is out of scope - let's just do a quick fix for Windows, and ship it as part of 0.5.5

Roger that!

@dan-menlo dan-menlo changed the title bug: Unable to use nitro.tensorRT-llm on linux bug: Fix Download location of Nitro TensorRT on Windows Sep 29, 2024
@dan-menlo dan-menlo moved this from Investigating to Scheduled in Menlo Sep 29, 2024
@github-project-automation github-project-automation bot moved this from In Review to Review + QA in Menlo Sep 30, 2024
@imtuyethan imtuyethan added this to the v0.5.5 milestone Oct 2, 2024
@imtuyethan imtuyethan moved this from Review + QA to Completed in Menlo Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: linux Linux issues type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants