fix: #3491 - Unable to use tensorrt-llm #3741
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR fixes the Tensor-LLM engine download URL, making it accessible to Windows users with supported Nvidia GPUs, who can now install and use Tensort-LLM models.
This also fixes the incorrect supported platforms from the extension, which currently only support Windows.
There's an edge case with model downloading on Windows that's been fixed, and it also resolved an issue where the renderer process would send a wrong aborting ID.
Screenshots
Fixes Issues
In
package.json
:scripts
section to include atest
commandIn
rollup.config.ts
:janhq/nitro-tensorrt-llm
tojanhq/cortex.tensorrt-llm
In
src/index.ts
:supportedPlatform
arraythis.compatibility().platform
instead ofthis.supportedPlatform
In
tsconfig.json
:exclude
field to ignore test filesIn
web/hooks/useDownloadModel.ts
:abortModelDownload
function to handleModelFile
instead ofModel
abortModelDownload
to usefile_path
when availableThese changes mainly focus on setting up Jest for testing, updating download URLs, refactoring some compatibility checks, and adjusting the model download abort functionality.