Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set ulimit by default in startup strategy #177

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

feddevanderlist
Copy link
Contributor

fix #176 and set ulimit so startup time is reduced on platforms that support it.

This has been built and tested on an pc running manjaro.

Copy link
Owner

@jarlah jarlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Super thanks for the contribution 🙌 i will look at this more later.

@feddevanderlist
Copy link
Contributor Author

@jarlah I made a mistake in my thinking fixed it now. It's building again and more resilient. I might make a new merge request tomorrow that cleans up the code a little bit if you're ok with it :)

@jarlah
Copy link
Owner

jarlah commented Nov 27, 2024

Thats ok. Just tell me when you feel the PR is ready

@feddevanderlist
Copy link
Contributor Author

it is ready now. Just saw some things in the code that I might wanna clean up. But that should not be part of this. Because I didn't make or change it. And it's your project :)

@jarlah
Copy link
Owner

jarlah commented Nov 27, 2024

it is ready now. Just saw some things in the code that I might wanna clean up. But that should not be part of this. Because I didn't make or change it. And it's your project :)

OUR project, anyone who contribute to this repo can call it OUR project :) im just a facilitator 🙇

@jarlah jarlah changed the title fix https://github.com/jarlah/testcontainers-ceph/issues/176 set ulimit default en startup strategy fix: set ulimit by default in startup strategy Nov 27, 2024
@jarlah jarlah force-pushed the feature/fix-startup-strategy branch from cccdffd to e09a887 Compare November 27, 2024 20:43
Copy link
Owner

@jarlah jarlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions

Copy link
Owner

@jarlah jarlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR looks good. It introduces new tests and fixes existing tests. The changes are understandable. Lets merge this. I will check if it builds and run the tests locally on rootless docker on nixos. WIll release if everything works

@jarlah jarlah merged commit 68883e1 into jarlah:main Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in Ceph container startupStrategy
2 participants