fix linter issues to be more in line with java rules

[feddevanderlist]

Fixing some linter issues based on the java-sonarcube-default rule set.

[feddevanderlist]

@jarlah I was wondering if for the tests we could put the comments in the code in java doc. That way code gets a little cleaner and more readable. :)

[jarlah]

You can move comments thats ok. But can you add automated code linting in workflow? If it possible to come to a state when where it breaks it dont show a list of 100 problems ?

[feddevanderlist]

You can move comments thats ok. But can you add automated code linting in workflow? If it possible to come to a state when where it breaks it dont show a list of 100 problems ?

I don't know about a way in github to do that. But I'll take a look to find out if it's possible :)

[feddevanderlist]

https://www.freecodecamp.org/news/github-super-linter/ this might be an option :)

[jarlah]

maybe you can test it out on your own fork. I see it requires a bit of a setup with secrets and stuff

[feddevanderlist]

I'll take a look I've never used github actions before. I'm a gitlab person.

[jarlah]

Chatgpt or perplexity ftw 🙈

[jarlah]

you can do that in different PR if you want. Just mark it ready when you have fixed the linting stuff you seem fitting

[jarlah]

might also be overly overkill with github action for linting java code when there is literally almost no code

[jarlah]

Looks good :)

i would recommend removing the silly one word "comment blocks" though