Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join process #80

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Join process #80

merged 1 commit into from
Sep 8, 2024

Conversation

jarrod-lowe
Copy link
Owner

No description provided.

Copy link

codacy-production bot commented Sep 8, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-18.57% 22.73%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f7e628d) 161 160 99.38%
Head commit (dca0290) 297 (+136) 240 (+80) 80.81% (-18.57%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#80) 22 5 22.73%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

github-actions bot commented Sep 8, 2024

Terraform plan in terraform/environment/wildsea
With backend config: bucket=terraform-state-021891603679 key=primary/terraform.tfstate region=ap-southeast-2

With variables

environment       = "primary"
saml_metadata_url = (sensitive value)
Plan: 0 to add, 1 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place

Terraform will perform the following actions:

  # module.wildsea.aws_appsync_function.function["fnJoinGame"] will be updated in-place
!~  resource "aws_appsync_function" "function" {
!~      code                      = <<-EOT
            // function/fnJoinGame/appsync.ts
            import { util } from "@aws-appsync/utils";
            
            // environment.json
            var environment_default = { name: "primary" };
            
            // lib/constants.ts
            var TypeCharacter = "CHARACTER";
            var DefaultPlayerCharacterName = "Unnamed Character";
            
            // function/fnJoinGame/appsync.ts
            function request(context) {
              if (!context.identity) {
                util.error("Unauthorized: Identity information is missing.");
              }
              const identity = context.identity;
              if (!identity.sub) {
                util.error("Unauthorized: User ID is missing.");
              }
              const id = context.arguments.input.gameId;
              const timestamp = util.time.nowISO8601();
              const gameItem = {
                operation: "UpdateItem",
                table: "Wildsea-" + environment_default.name,
                key: util.dynamodb.toMapValues({
                  PK: "GAME#" + id,
                  SK: "GAME"
                }),
                update: {
                  expression: "ADD #players :player SET #updatedAt = :updatedAt",
                  expressionNames: {
                    "#players": "players",
                    "#updatedAt": "updatedAt"
                  },
                  expressionValues: {
                    ":player": { SS: [identity.sub] },
                    ":updatedAt": { S: timestamp }
                  }
                }
              };
              const playerItem = {
                operation: "PutItem",
                table: "Wildsea-" + environment_default.name,
                key: util.dynamodb.toMapValues({
                  PK: "GAME#" + id,
                  SK: "PLAYER#PC#" + identity.sub
                }),
                attributeValues: util.dynamodb.toMapValues({
                  gameId: id,
                  userId: identity.sub,
                  GSI1PK: "USER#" + identity.sub,
                  gameName: context.prev.result.gameName,
                  gameDescription: context.prev.result.gameDescription,
                  characterName: DefaultPlayerCharacterName,
                  type: TypeCharacter,
                  createdAt: timestamp,
                  updatedAt: timestamp
                })
              };
              return {
                operation: "TransactWriteItems",
                transactItems: [gameItem, playerItem]
              };
            }
            function response(context) {
              if (context.error) {
                util.error(context.error.message, context.error.type, context.result);
              }
              context.prev.result.joinToken = null;
          +   context.prev.result.playerSheets = [];
              return context.prev.result;
            }
            export {
              request,
              response
            };
          - //# sourceMappingURL=data:application/json;base64,ewogICJ2ZXJzaW9uIjogMywKICAic291cmNlcyI6IFsiYXBwc3luYy50cyIsICIuLi8uLi9lbnZpcm9ubWVudC5qc29uIiwgIi4uLy4uL2xpYi9jb25zdGFudHMudHMiXSwKICAibWFwcGluZ3MiOiAiO0FBQUEsU0FBUyxZQUE2Qzs7O0FDQXRELDRCQUFDLE1BQU8sVUFBUzs7O0FDQ1YsSUFBTSxnQkFBZ0I7QUFLdEIsSUFBTSw2QkFBNkI7OztBRkFuQyxTQUFTLFFBQVEsU0FBcUQ7QUFDM0UsTUFBSSxDQUFDLFFBQVEsVUFBVTtBQUNyQixTQUFLLE1BQU0sZ0RBQTBEO0FBQUEsRUFDdkU7QUFFQSxRQUFNLFdBQVcsUUFBUTtBQUN6QixNQUFJLENBQUMsU0FBUyxLQUFLO0FBQ2pCLFNBQUssTUFBTSxtQ0FBNkM7QUFBQSxFQUMxRDtBQUVBLFFBQU0sS0FBSyxRQUFRLFVBQVUsTUFBTTtBQUNuQyxRQUFNLFlBQVksS0FBSyxLQUFLLFdBQVc7QUFFdkMsUUFBTSxXQUFXO0FBQUEsSUFDZixXQUFXO0FBQUEsSUFDWCxPQUFPLGFBQWEsb0JBQVk7QUFBQSxJQUNoQyxLQUFLLEtBQUssU0FBUyxZQUFZO0FBQUEsTUFDN0IsSUFBSSxVQUFVO0FBQUEsTUFDZCxJQUFJO0FBQUEsSUFDTixDQUFDO0FBQUEsSUFDRCxRQUFRO0FBQUEsTUFDTixZQUFZO0FBQUEsTUFDWixpQkFBaUI7QUFBQSxRQUNmLFlBQVk7QUFBQSxRQUNaLGNBQWM7QUFBQSxNQUNoQjtBQUFBLE1BQ0Esa0JBQWtCO0FBQUEsUUFDaEIsV0FBVyxFQUFFLElBQUksQ0FBQyxTQUFTLEdBQUcsRUFBRTtBQUFBLFFBQ2hDLGNBQWMsRUFBRSxHQUFHLFVBQVU7QUFBQSxNQUMvQjtBQUFBLElBQ0Y7QUFBQSxFQUNGO0FBRUEsUUFBTSxhQUFhO0FBQUEsSUFDakIsV0FBVztBQUFBLElBQ1gsT0FBTyxhQUFhLG9CQUFZO0FBQUEsSUFDaEMsS0FBSyxLQUFLLFNBQVMsWUFBWTtBQUFBLE1BQzdCLElBQUksVUFBVTtBQUFBLE1BQ2QsSUFBSSxlQUFlLFNBQVM7QUFBQSxJQUM5QixDQUFDO0FBQUEsSUFDRCxpQkFBaUIsS0FBSyxTQUFTLFlBQVk7QUFBQSxNQUN6QyxRQUFRO0FBQUEsTUFDUixRQUFRLFNBQVM7QUFBQSxNQUNqQixRQUFRLFVBQVUsU0FBUztBQUFBLE1BQzNCLFVBQVUsUUFBUSxLQUFLLE9BQU87QUFBQSxNQUM5QixpQkFBaUIsUUFBUSxLQUFLLE9BQU87QUFBQSxNQUNyQyxlQUFlO0FBQUEsTUFDZixNQUFNO0FBQUEsTUFDTixXQUFXO0FBQUEsTUFDWCxXQUFXO0FBQUEsSUFDYixDQUFDO0FBQUEsRUFDSDtBQUVBLFNBQU87QUFBQSxJQUNMLFdBQVc7QUFBQSxJQUNYLGVBQWUsQ0FBQyxVQUFVLFVBQVU7QUFBQSxFQUN0QztBQUNGO0FBRU8sU0FBUyxTQUNkLFNBQ2tCO0FBQ2xCLE1BQUksUUFBUSxPQUFPO0FBQ2pCLFNBQUssTUFBTSxRQUFRLE1BQU0sU0FBUyxRQUFRLE1BQU0sTUFBTSxRQUFRLE1BQU07QUFBQSxFQUN0RTtBQUVBLFVBQVEsS0FBSyxPQUFPLFlBQVk7QUFDaEMsU0FBTyxRQUFRLEtBQUs7QUFDdEI7IiwKICAibmFtZXMiOiBbXQp9Cg==
          + //# sourceMappingURL=data:application/json;base64,ewogICJ2ZXJzaW9uIjogMywKICAic291cmNlcyI6IFsiYXBwc3luYy50cyIsICIuLi8uLi9lbnZpcm9ubWVudC5qc29uIiwgIi4uLy4uL2xpYi9jb25zdGFudHMudHMiXSwKICAibWFwcGluZ3MiOiAiO0FBQUEsU0FBUyxZQUE2Qzs7O0FDQXRELDRCQUFDLE1BQU8sVUFBUzs7O0FDQ1YsSUFBTSxnQkFBZ0I7QUFLdEIsSUFBTSw2QkFBNkI7OztBRkFuQyxTQUFTLFFBQVEsU0FBcUQ7QUFDM0UsTUFBSSxDQUFDLFFBQVEsVUFBVTtBQUNyQixTQUFLLE1BQU0sZ0RBQTBEO0FBQUEsRUFDdkU7QUFFQSxRQUFNLFdBQVcsUUFBUTtBQUN6QixNQUFJLENBQUMsU0FBUyxLQUFLO0FBQ2pCLFNBQUssTUFBTSxtQ0FBNkM7QUFBQSxFQUMxRDtBQUVBLFFBQU0sS0FBSyxRQUFRLFVBQVUsTUFBTTtBQUNuQyxRQUFNLFlBQVksS0FBSyxLQUFLLFdBQVc7QUFFdkMsUUFBTSxXQUFXO0FBQUEsSUFDZixXQUFXO0FBQUEsSUFDWCxPQUFPLGFBQWEsb0JBQVk7QUFBQSxJQUNoQyxLQUFLLEtBQUssU0FBUyxZQUFZO0FBQUEsTUFDN0IsSUFBSSxVQUFVO0FBQUEsTUFDZCxJQUFJO0FBQUEsSUFDTixDQUFDO0FBQUEsSUFDRCxRQUFRO0FBQUEsTUFDTixZQUFZO0FBQUEsTUFDWixpQkFBaUI7QUFBQSxRQUNmLFlBQVk7QUFBQSxRQUNaLGNBQWM7QUFBQSxNQUNoQjtBQUFBLE1BQ0Esa0JBQWtCO0FBQUEsUUFDaEIsV0FBVyxFQUFFLElBQUksQ0FBQyxTQUFTLEdBQUcsRUFBRTtBQUFBLFFBQ2hDLGNBQWMsRUFBRSxHQUFHLFVBQVU7QUFBQSxNQUMvQjtBQUFBLElBQ0Y7QUFBQSxFQUNGO0FBRUEsUUFBTSxhQUFhO0FBQUEsSUFDakIsV0FBVztBQUFBLElBQ1gsT0FBTyxhQUFhLG9CQUFZO0FBQUEsSUFDaEMsS0FBSyxLQUFLLFNBQVMsWUFBWTtBQUFBLE1BQzdCLElBQUksVUFBVTtBQUFBLE1BQ2QsSUFBSSxlQUFlLFNBQVM7QUFBQSxJQUM5QixDQUFDO0FBQUEsSUFDRCxpQkFBaUIsS0FBSyxTQUFTLFlBQVk7QUFBQSxNQUN6QyxRQUFRO0FBQUEsTUFDUixRQUFRLFNBQVM7QUFBQSxNQUNqQixRQUFRLFVBQVUsU0FBUztBQUFBLE1BQzNCLFVBQVUsUUFBUSxLQUFLLE9BQU87QUFBQSxNQUM5QixpQkFBaUIsUUFBUSxLQUFLLE9BQU87QUFBQSxNQUNyQyxlQUFlO0FBQUEsTUFDZixNQUFNO0FBQUEsTUFDTixXQUFXO0FBQUEsTUFDWCxXQUFXO0FBQUEsSUFDYixDQUFDO0FBQUEsRUFDSDtBQUVBLFNBQU87QUFBQSxJQUNMLFdBQVc7QUFBQSxJQUNYLGVBQWUsQ0FBQyxVQUFVLFVBQVU7QUFBQSxFQUN0QztBQUNGO0FBRU8sU0FBUyxTQUNkLFNBQ2tCO0FBQ2xCLE1BQUksUUFBUSxPQUFPO0FBQ2pCLFNBQUssTUFBTSxRQUFRLE1BQU0sU0FBUyxRQUFRLE1BQU0sTUFBTSxRQUFRLE1BQU07QUFBQSxFQUN0RTtBQUVBLFVBQVEsS0FBSyxPQUFPLFlBQVk7QUFDaEMsVUFBUSxLQUFLLE9BQU8sZUFBZSxDQUFDO0FBQ3BDLFNBQU8sUUFBUSxLQUFLO0FBQ3RCOyIsCiAgIm5hbWVzIjogW10KfQo=
        EOT
        id                        = "tfiz6mnf2nhyzpzkwm554sir5q-ivdn34xr4jb53adwa6nj6ix7rm"
        name                      = "fnJoinGame"
#        (9 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

✅ Plan applied in Environment Main - Apply #75

Outputs
cdn_domain_name          = "d3tinvgatp7lle.cloudfront.net"
cdn_id                   = "E2KPUTZ78NDDZ6"
cognito_identity_pool_id = "ap-southeast-2:2c578a4f-3fd8-453e-860d-4fde2187c38e"
cognito_login_domain     = "wildsea-primary.auth.ap-southeast-2.amazoncognito.com"
cognito_user_pool_id     = "ap-southeast-2_mi8U4SiYJ"
cognito_web_client_id    = "1ghmru9nk0j81l040lehbgosv1"
graphql_uri              = "https://2xdx2rdnwjbyznwjz4nc54dzbi.appsync-api.ap-southeast-2.amazonaws.com/graphql"
region                   = "ap-southeast-2"
ui_bucket                = "wildsea-primary-ui"

Copy link

sonarqubecloud bot commented Sep 8, 2024

@jarrod-lowe jarrod-lowe merged commit ddc6944 into main Sep 8, 2024
7 checks passed
@jarrod-lowe jarrod-lowe deleted the work branch September 8, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant