Document sort actions #2004
Merged
Document sort actions #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarun
requested changes
Feb 19, 2025
N-R-K
reviewed
Feb 22, 2025
MatthiasKunnen
added a commit
to MatthiasKunnen/nnn
that referenced
this pull request
Feb 22, 2025
This reverts commit 0ccf64d. Rejected, see jarun#2004 (comment).
|
Can you please squash all the commits into one? |
- Document sort order in the man page - Fix typo in zsh completion - Explain sort order options in fish completions
MatthiasKunnen
force-pushed
the
sort-usage
branch
from
18f59c9 to
272ecc2
Compare
Done |
|
Thank you! |
|
Happy to contribute! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actions in the Sort toggles (
t) prompt were not very clear to me and lead to a lot of looking up with some confusion:'a'u/'d'u/'e'xt/'r'ev/'s'z/'t'm/'v'er/'c'lr/'^T'?So I dove into the source to find out what all the options do and added a help option.
Now, when responding to the prompt with
?, the info of the options is displayed. This follows the Don't memorize! approach taken by nnn.The same approach as the general help is employed. I have looked into reusing the same code for both help functions but did not find a clean way to do it.
Regarding the order of the usage info, I debated between same order as the prompt, alphabetical, and grouped by type (e.g. all file size/disk usage together) and decided on alphabetical. If you would like prompt order, or any other order, let me know.
The binary size did not increase, to my surprise, it stayed at 126 440 B (compiled on x64 Arch Linux, gcc 14.2.1 20250207).