Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Jison compiles
parser.js
very slowly:Since the parser is also compiled whenever we run
cake build
, this means any change to the compiler takes ~12 seconds to reload (or almost 30 seconds if you runcake build
twice!).Solution
Result
The generated parser seems to be byte-for-byte the same, while being generated much faster:
We can go even faster (https://github.com/cosmicexplorer/jison/tree/performance-work-for-coffeescript), but the additional changes in that branch are quite extensive, and don't produce a significant performance improvement. This change is easy to audit and does most of the work.
TODO
package.json
entry points to my own github user repository. It's pinned to a commit, so it can't change, but if we're going to use a git reference, it should probably be owned by a maintainer of the repo.