Suggestion: Add check in rulecat.py if sid is None as otherwise script aborts #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
recently I was running rulecat.py but unfortunately I had an error in my local.rules file but as I had over 250 local rules in that file I could not figure out where exactly the problem was as the script just aborted in the following line with an error ("None can not be converted to int" if I remember well)
https://github.com/security-companion/py-idstools/blob/7c567d3ccbf58a50c3964d7115d2745f6c353821/idstools/rule.py#LL127C9-L127C46
Therefore I would like to suggest the following change which adds a print of the rule that caused the failure which then makes fixing the syntax easier.
Looking forward to your thought.
security-companion