feat: Support ftp when using FlyteFile (flyteorg#2409)

* feat: Support ftp when using FlyteFile Signed-off-by: ggydush <[email protected]> * fix: Use optional instead Signed-off-by: ggydush <[email protected]> --------- Signed-off-by: ggydush <[email protected]>
jasonlai1218 · May 11, 2024 · c36f322 · c36f322
1 parent 0d4981b
commit c36f322
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/flytekit/core/data_persistence.py b/flytekit/core/data_persistence.py
@@ -180,7 +180,11 @@ def raw_output_fs(self) -> fsspec.AbstractFileSystem:
         return self._default_remote
 
     def get_filesystem(
-        self, protocol: typing.Optional[str] = None, anonymous: bool = False, **kwargs
+        self,
+        protocol: typing.Optional[str] = None,
+        anonymous: bool = False,
+        path: typing.Optional[str] = None,
+        **kwargs,
     ) -> fsspec.AbstractFileSystem:
         if not protocol:
             return self._default_remote
@@ -195,6 +199,9 @@ def get_filesystem(
             if anonymous:
                 kwargs["token"] = _ANON
             return fsspec.filesystem(protocol, **kwargs)  # type: ignore
+        elif protocol == "ftp":
+            kwargs.update(fsspec.implementations.ftp.FTPFileSystem._get_kwargs_from_urls(path))
+            return fsspec.filesystem(protocol, **kwargs)
 
         storage_options = get_fsspec_storage_options(
             protocol=protocol, anonymous=anonymous, data_config=self._data_config, **kwargs
@@ -204,7 +211,7 @@ def get_filesystem(
 
     def get_filesystem_for_path(self, path: str = "", anonymous: bool = False, **kwargs) -> fsspec.AbstractFileSystem:
         protocol = get_protocol(path)
-        return self.get_filesystem(protocol, anonymous=anonymous, **kwargs)
+        return self.get_filesystem(protocol, anonymous=anonymous, path=path, **kwargs)
 
     @staticmethod
     def is_remote(path: Union[str, os.PathLike]) -> bool: