rename eval.wrap to eval.container #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wrap` is used at the top-level of settings for wrapping at a certain column, and inside `eval` to determine the type in which the result is "wrapped". Using the same name for both is confusing, so this adds `eval.container` as the new name for `eval.wrap`. `eval.wrap` will continue to be supported for the forseeable future, but its use will be discouraged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrapis used at the top-level of settings for wrapping at a certain column, and insideevalto determine the type in which the result is "wrapped". Using the same name for both is confusing, so this addseval.containeras the new name foreval.wrap.eval.wrapwill continue to be supported for the forseeable future, but its use will be discouraged.This also changes the values (again keeping the original ones for backwards-compat), so the complete changes to a configuration would be:
wrap: code->container: codewrap: raw->container: nonewrap: rawInline->container: inline