Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor simplification: replace binShrinkL and binShrinkR with bin #52

Merged
merged 1 commit into from
Oct 6, 2023
Merged

minor simplification: replace binShrinkL and binShrinkR with bin #52

merged 1 commit into from
Oct 6, 2023

Conversation

mitchellwrosen
Copy link
Contributor

Hi!

I noticed binShrinkL and binShrinkR are the same function; this PR renames it to bin, and deletes the duplicate.

jaspervdj
jaspervdj approved these changes Oct 3, 2023
View reviewed changes
Copy link
Owner

@jaspervdj jaspervdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good!

@jaspervdj jaspervdj merged commit 3e8ed5f into jaspervdj:master Oct 6, 2023
@mitchellwrosen
Copy link
Contributor Author

No problem! By the way, I noticed base has a copy of this data structure, to which the same patch could apply: https://hackage.haskell.org/package/base-4.18.1.0/docs/src/GHC.Event.PSQ.html

Do you know how that relationship is managed? Is someone perhaps watching both repos and porting fixes and improvements to both places?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaspervdj jaspervdj jaspervdj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchellwrosen @jaspervdj