Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return codes for old field classifications #105

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

jatkinson1000
Copy link
Owner

@jatkinson1000 jatkinson1000 commented Dec 9, 2024

Fixes #104

Replaces the return array values with codes instead ['GMB', 'MB', 'B', '1C', '2C', '3C', 'UC'], and any unclassified by 'UC'.

Tests also updated to match new return values.

@jatkinson1000 jatkinson1000 self-assigned this Dec 9, 2024
@jatkinson1000
Copy link
Owner Author

@TomHall2020 how do you feel about this?

@TomHall2020
Copy link
Contributor

Ooh, nice. Gives me a reference to use for the codes to use for the old outdoor system too, and I definitely like 1C for first class, for some reason I coudln't think of that when I was trying to shorten the codes.

Wondered about assigning a global constant UNCLASSIFIED="UC" for DRY purposes, and could also think about making the list of codes a module level constant as well, could be handy for introspection, but those are seasoning. Rest is simple enough, reccomend merging it in.

@jatkinson1000
Copy link
Owner Author

Debated on this a little as it doesn't match the new setups, but given the differences (an this being somewhat legacy/separate) I think it makes sense. Done both in 215c852

@jatkinson1000 jatkinson1000 merged commit 4aab80f into main Jan 24, 2025
15 checks passed
@jatkinson1000 jatkinson1000 deleted the old_field_UC branch January 24, 2025 07:39
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (ad97498) to head (215c852).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files          30       30           
  Lines        1747     1748    +1     
=======================================
+ Hits         1709     1710    +1     
  Misses         38       38           
Files with missing lines Coverage Δ
...s/classifications/agb_old_field_classifications.py 100.00% <100.00%> (ø)
...yutils/classifications/tests/test_agb_old_field.py 100.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old field classifications return words not codes for classifications
2 participants