-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return codes for old field classifications #105
Conversation
@TomHall2020 how do you feel about this? |
Ooh, nice. Gives me a reference to use for the codes to use for the old outdoor system too, and I definitely like Wondered about assigning a global constant |
f8afa8d
to
d56b69b
Compare
d56b69b
to
215c852
Compare
Debated on this a little as it doesn't match the new setups, but given the differences (an this being somewhat legacy/separate) I think it makes sense. Done both in 215c852 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 30 30
Lines 1747 1748 +1
=======================================
+ Hits 1709 1710 +1
Misses 38 38
|
Fixes #104
Replaces the return array values with codes instead
['GMB', 'MB', 'B', '1C', '2C', '3C', 'UC']
, and any unclassified by'UC'
.Tests also updated to match new return values.