Cleaning and Tests #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JP paper. Added 5mm diameter arrow for Archery Australia calculations to match JP paper. Added 5mm diameter arrow for Archery Australia calculations to match JP paper.
jatkinson1000
added
enhancement
|
So far checking with coverage: 21% handicap functions - needs tests for root finding, missing print from handicap table Consider opening a fresh issue for adding classification tests as this is a relatively large job. |
|
Found bug in calculation of integer precision of negative handicaps whilst writing tests. handicap functions coverage now at 68% only missing print_table function and a couple of untriggered parts of rootfinding algorithm. Opened issues #22 highlighting lack data for of AA2 tests and #23 requesting classification tests as this PR is already large. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning with black, pylint, refurb, pydocstyle (numpy) for a better codebase.
Adding testing:
Classifications- moved to Tests needed for classifications #23Will close #18